search

SwitchEV / RISE-V2G

The only fully-featured reference implementation of the Vehicle-2-Grid communication interface ISO 15118
MIT License
220 stars 92 forks source link

Find the network interface by index on windows operating systems. #10

Closed Sevenstax closed 7 years ago

Sevenstax commented 7 years ago

I had problems getting this project to run on a windows operating system. On windows the network interfaces are accessed by index not by name.

MarcMueltin commented 7 years ago

Basically a good idea. Yet, I like to keep the library dependencies to a minimum and would, therefore, alter your pull request a bit using System.getProperty("os.name"). See also: https://stackoverflow.com/questions/14288185/detecting-windows-or-linux

Will look into it and then proceed when finished testing.

Sevenstax commented 7 years ago

That's right. It's a good idea to keep library dependancies low. I changed the detection to the proposed function.

MarcMueltin commented 7 years ago

Thanks for the change. Seems to be a good solution.