ScheduleExchangeRes parsing fix

SwitchEV / iso15118

Implementation of the ISO 15118 Communication Protocol (-2, -20, -8)

Apache License 2.0

147 stars 82 forks source link

Closed heavyweight87 closed 3 months ago

heavyweight87 commented 3 months ago

ScheduleExchangeResponse parser was checking that either absolute or price levels were set, which according to the standard both are optional in this case
Fixed an issue where charging was not disabled when the session stopped abruptly (due to parsing errors etc)
Fixed an issue with charging_enabled not being called in the correct place for ISO-20
Fixed power delivery request not checking which service is currently being used for ISO-20
Fixed an issue with BPT power profiles causing an exception for ISO-20

shalinnijel2 commented 3 months ago

Thanks for this @heavyweight87 . I had to double check this in the -20 user group before approving. I see this issue is clarified here: https://iso15118.elaad.io/pt2/15118-20/user-group/-/issues/27

heavyweight87 commented 3 months ago

Thanks! I will close the issue

heavyweight87 commented 3 months ago

Accidently closed the MR I thougt it was already merged :)

heavyweight87 commented 3 months ago

Hi, Any chances of merging this?

shalinnijel2 commented 3 months ago

Done - just got back from holiday today. Thank you for this @heavyweight87 . :).

heavyweight87 commented 3 months ago

Thanks! Sorry to rush you... hope you had fun :)