search

SwitchEV / iso15118

Implementation of the ISO 15118 Communication Protocol (-2, -20, -8)
Apache License 2.0
147 stars 82 forks source link

Bug in PydanticBaseModel for ISO20 Messages #399

Closed TGruett closed 1 month ago

TGruett commented 2 months ago

Hi,

i figured out two problems with the pydantic model for ISO 20 while testing the schedule mode.

While the fix of the first problem is straight forward, the id attribute in the AbsolutePriceSchedule is a bit more complex. I'm not sure how to properly model elements of type xs:ID, especially its uniqueness. Perhaps someone else knows how to deal with this?

Thank You.

shalinnijel2 commented 1 month ago

Thank you for reporting this @TGruett :). I have opened a PR for this and will include this in the next release. Kind regards, Shalin.