SwitchbladeBot / switchblade

The open source Discord bot that solves all of your problems.
https://switchblade.xyz/
BSD 4-Clause "Original" or "Old" License
424 stars 224 forks source link

Translate phrases to emoji command #1313

Closed MoPaMo closed 1 year ago

MoPaMo commented 3 years ago

Based on my issue#1312, I have now created a command, which takes user input and translates the words into emojis. Right now, the command has a pretty small range of translations, but I think finding new and fun translation is a great thing for PRs.

I've just tested the algorithm itself and haven't run the entire project myself yet, so I'm not sure whether I "registered" my command...

MoPaMo commented 3 years ago

I feel like it would be better if you used the emojis directly (😅) instead of keeping the :emoji_name: format

Why? They are converted to emojis by discord and I'm not even sure if the "normal" emojis work…

almeidx commented 3 years ago

I feel like it would be better if you used the emojis directly (sweat_smile) instead of keeping the :emoji_name: format

Why? They are converted to emojis by discord and I'm not even sure if the "normal" emojis work…

It would probably make the code easier to read, but it's not a big deal

MoPaMo commented 3 years ago

I don't know 🤷🏼‍♂️ 😂

almeidx commented 3 years ago

Github Actions are sort of dying atm so the checks aren't running, however, whenever they get back up they are going to fail in this pull request because we do not allow semicolons.

For the time being, you can run npm run fix and npm run test locally to see what needs fixing, which is basically what the github actions would have done if they were working

MoPaMo commented 3 years ago

I fixed the problems called out by the linter program, so what do I do now?

MoPaMo commented 3 years ago

I‘m kind of frustrated right now - what did I do wrong so I don’t get any answer in two weeks? 🙈

Doges commented 3 years ago

I‘m kind of frustrated right now - what did I do wrong so I don’t get any answer in two weeks? 🙈

nothing, i don't have enough time to test it rn, may take more 4 days for my review

MoPaMo commented 3 years ago

I‘m kind of frustrated right now - what did I do wrong so I don’t get any answer in two weeks? 🙈

nothing, i don't have enough time to test it rn, may take more 4 days for my review

Sorry for being annoying 😅