search

Swivel-Finance / gost

Smart contract testing with Geth via the Golang ABIGEN
20 stars 2 forks source link

cancel does not need sig components and hashing overhead #438

Closed robrobbins closed 2 years ago

robrobbins commented 2 years ago

this is a suggestion from: https://github.com/code-423n4/2022-07-swivel-findings/issues/165

tl;dr - when cancelling an order(s) you don't need to signature check - just check that msg.sender is order.maker

if we are comforable with that -- it's a bit less code and processing. no strong feelings from me either way.

robrobbins commented 2 years ago

also gatta get a spec on this. will do before merging.