search

Swivelgames / PureModals

A "pure" javascript modal library for creating tooltips, interstitials, very basic and simple modals, and even complex step-based modal windows.
GNU General Public License v3.0
1 stars 0 forks source link

Issue with target link opening multiple modals (and overlays) #2

Open jerkyb opened 8 years ago

jerkyb commented 8 years ago

Hey there. When clicking a target to open a modal the user is able to fire multiple instances and overlays if they're fast enough in clicking the link.

Swivelgames commented 8 years ago

Hey Andrew,

Thanks for the issue. I was able to fix this by modifying the Modal class to halt opening new modals until the first one clicked is open. This should solve the issue. I'll be implementing the fix and pushing up a PR shortly. Because B&N requires IE9 support, the version you guys are running will require you to make these edits manually.

Just let me know when you've got time to do a Hangouts call and I'll walk you through the fix.

In addition, the PR should outline the changes I made, so it should be simple enough to implement without any help. But I'm more than happy to help you out with it.

jerkyb commented 8 years ago

Yup, I should be able to follow your PR tomorrow. I'll be sure to ping you if I have any issues. Thanks for looking into it for me! On Oct 22, 2015 9:45 PM, "Joseph Dalrymple" notifications@github.com wrote:

Hey Andrew,

Thanks for the issue. I was able to fix this by modifying the Modal class to halt opening new modals until the first one clicked is open. This should solve the issue. I'll be implementing the fix and pushing up a PR shortly. Because B&N requires IE9 support, the version you guys are running will require you to make these edits manually.

Just let me know when you've got time to do a Hangouts call and I'll walk you through the fix.

In addition, the PR should outline the changes I made, so it should be simple enough to implement without any help. But I'm more than happy to help you out with it.

— Reply to this email directly or view it on GitHub https://github.com/Swivelgames/PureModals/issues/2#issuecomment-150419645 .