Swoffa / SublimeKickAssemblerC64

Sublime Package for C64 development with Kick Assembler.
47 stars 15 forks source link

Added kickass_startup_file_root_path #36

Closed daleicious closed 6 years ago

daleicious commented 6 years ago

I have been working on a project with a large number of asm files, organized into many folders. While working, it became onerous to make a change in a file in a subfolder, then hunt for the Startup.asm file in my main folder (or another file in the same root folder) and activate that file in Sublime, before hitting F5 to test my changes.

With this pull request, I've added a new setting, "kickass_startup_file_root_path", which can be set to a fully qualified path to the folder containing the "Startup.asm" to be compiled and run when F5/Shift-F5 are pressed.

Now we can have a robust file folder structure and have a single Startup.asm that will be built and run whenever we hit F5 from any asm file in our tree.

Note that this is they first time I've coded in Python, so I cannot vouch for the voracity of my code, and I may not have tested all the variations of settings in the Sublime package. I did test F5 vs F7 on Windows and both behaved as I would have expected.

Anyway I figured I'd fork the project and send you a PR in case you wanted to include this for others to use (tho please carefully review my code if you do merge the PR since I'm a n00b with Python and Sublime package development!)

daleicious commented 6 years ago

Oh one important note: the path provided MUST end with "/" - ie, "c:/projects/mygame/src/".

Swoffa commented 6 years ago

Thanks @daleicious! Thats great. Will review and test soon.

Swoffa commented 6 years ago

@daleicious Inspired by the changes you suggested in this PR, I did the same thing but also with support for pre/post/make-scripts. It is available in PR #38 and branch startup_root_path.

The setting name is kickass_startup_root_path, so thats a difference.

Can you please review and test if it does the same thing that you intended this PR to do.

Many thanks again!!

Swoffa commented 6 years ago

Closing this. We continue with #38 instead.