search

Swofty-Developments / HypixelSkyBlock

Minecraft 1.8-1.21 (no Spigot) recreation of Hypixel SkyBlock with a goal of a properly abstracted and scalable codebase.
https://discord.gg/paper
GNU Affero General Public License v3.0
105 stars 41 forks source link

[BUG] NPC shop prices incorrect #217

Closed TreesOnTop closed 5 months ago

TreesOnTop commented 5 months ago

Some NPCs have incorrect shop prices, for example the mine merchant sells 2 coal for 8 coins on Hypixel whereas here it costs 8 coins per coal this applies to every item in the mine merchant and possibly other NPCs I that have yet to check.

TreesOnTop commented 5 months ago

I checked most of the shops and most have the same issue besides farm merchant, and it can be fixed by just diving the cost by the amount. I also noticed that all items have a limit of 640 items when most are normally unlimited.

TreesOnTop commented 5 months ago

incorrect prices fixed by #220

ItzKatze commented 5 months ago

actually fixed in #222

TreesOnTop commented 5 months ago

basically fixed except for arrows which aren't bought in multiples of 12

TreesOnTop commented 5 months ago

nvm this uses integer division when calculating the prices which means that for some items its way cheaper to buy in multiples of 1 than the default value and some weirdness like 32 torches can be bought for 32 coins or 16 coins

Swofty-Developments commented 5 months ago

Fixed in latest commit