search

Swoorup / dgraph-rs

A dgraph client driver written in rust ⛺
https://crates.io/crates/dgraph
MIT License
98 stars 10 forks source link

[doc] add reference to compile requirements #11

Closed Swaagie closed 5 years ago

Swaagie commented 5 years ago

Was running into build failures due to not having go and protoc on my system by default. Imho I think this is the easiest way of referring to requirements, without having to maintain a list here.

Thanks for this awesome module.

ondrowan commented 5 years ago

This is already fixed in master version (protobufs are pre-generated) which isn’t released yet.

On Wed, 18 Sep 2019 at 14:17, Martijn Swaagman notifications@github.com wrote:

Was running into build failures due to not having go and protoc on my system by default. Imho I think this is the easiest way of referring to requirements, without having to maintain a list here.

Thanks for this awesome module.

You can view, comment on, or merge this pull request online at:

https://github.com/Swoorup/dgraph-rs/pull/11 Commit Summary

  • [doc] add reference to compile requirements

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Swoorup/dgraph-rs/pull/11?email_source=notifications&email_token=AADHOYEWMXN7VRTPSLX3I2DQKIL4LA5CNFSM4IX53CR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMD7JPA, or mute the thread https://github.com/notifications/unsubscribe-auth/AADHOYEJ54DPIRQUBJJBNFLQKIL4LANCNFSM4IX53CRQ .

-- Ondrej Slinták

ondrowan commented 5 years ago

@Swoorup would it be possible to release version 0.2.0?

Swoorup commented 5 years ago

@Swaagie appreciate the contribution.

@ondrowan apologies, been a lot busier in other aspects lately, so have been lagging a bit behind on this. Do you mind giving me your username in crates.io so I can give you the publish rights?

ondrowan commented 5 years ago

@Swoorup Here it is: https://crates.io/users/ondrowan Thanks!

@Swaagie I'll publish a new version as soon as possible and let you know, so you can try it out and give us feedback.

Swoorup commented 5 years ago

Have sent you an invite

ondrowan commented 5 years ago

@Swoorup Thanks!

@Swaagie I have just published v0.2.0. I'd appreciate if you could test it whenever you have time. I have found out grpcio itself needs some tools to be installed, so I've also documented that in readme. I previously thought this PR addresses the issue with protobuf compilation which I've fixed earlier, so sorry for the confusion.

Swaagie commented 5 years ago

@ondrowan @Swoorup thanks for the release of v0.2.0. It builds and works fine as far as I can tell. I still have limited implementations against it on my end though. protoc is no longer required to build, nice improvement.