Closed ondrowan closed 5 years ago
Apologies for the delay. I have been busy with other stuffs. I am happy with the changes. This is a pretty good start. Happy to merge in as is, and we can integrate it with CI later
@Swoorup As you can see, I was swamped with work lately as well 😀 I've comitted everything from my checklist, but I cannot figure out why that one test fails. Could it be some bug? I've compared it with implementation and tests from dgraph-io/dgraph-js and the code seems to be the same. Could you check it once you have some time to spare?
@Swoorup since I'd like to work on other things I temporarily commented the failing test out and will figure out what's happening over there later. It'd be still cool if you looked at it as well.
Happy with the changes so far 👍
This is just a draft, so you can check how tests look like. It relates to #5.
cargo test -- --test-threads=1
since Dgraph likes to abort transactions if it modifies the same data at the same time. This is not documented yet.uid
queries since those always resolve.it_discards_a_transaction
fails for some reason and I'm not sure why.discard
complains thatTransaction has been aborted. Please retry.
, but I don't see a reason why. I'll look into it later.