Swoorup / dgraph-rs

A dgraph client driver written in rust ⛺
https://crates.io/crates/dgraph
MIT License
98 stars 10 forks source link

Add integration tests #7

Closed ondrowan closed 5 years ago

ondrowan commented 5 years ago

This is just a draft, so you can check how tests look like. It relates to #5.

Swoorup commented 5 years ago

Apologies for the delay. I have been busy with other stuffs. I am happy with the changes. This is a pretty good start. Happy to merge in as is, and we can integrate it with CI later

ondrowan commented 5 years ago

@Swoorup As you can see, I was swamped with work lately as well 😀 I've comitted everything from my checklist, but I cannot figure out why that one test fails. Could it be some bug? I've compared it with implementation and tests from dgraph-io/dgraph-js and the code seems to be the same. Could you check it once you have some time to spare?

ondrowan commented 5 years ago

@Swoorup since I'd like to work on other things I temporarily commented the failing test out and will figure out what's happening over there later. It'd be still cool if you looked at it as well.

Swoorup commented 5 years ago

Happy with the changes so far 👍