search

Swordfish90 / Lemuroid

All in one emulator on Android!
GNU General Public License v3.0
2.7k stars 166 forks source link

[Bug] Non-native mGBA save files not being recognized #156

Closed anthonyajumelles closed 3 years ago

anthonyajumelles commented 3 years ago

Sun's far I have only seen this happening with GBA, will see if it's an issue with other emulators as well.

I start Golden Sun from my phone and save a few minutes in.

From my PC, I can load RetroArch and use the mGBA core to continue the save file. I then save after a few more minutes of playing.

The issue is that, when I go back to Lemuroid, the save file isn't detected and the game acts as if I am starting fresh.

//

Lemuroid doesn't recognize mGBA save files from mGBA desktop (renamed to .SRM) nor from mGBA's RetroArch Android core.

//

Wasn't able to replicate this bug with SNES so it seems it's limited to mGBA. Super Mario RPG and FFVI detected the save file post saving in RetroArch Android and RetroArch Desktop.

I was able to see the issue present with Castlevania - Circle of the Moon as well.

Swordfish90 commented 3 years ago

Hi @anthonyajumelles thank you for the report. Can you please attach the culprit srm file? I'd like to perform a few tests on it.

anthonyajumelles commented 3 years ago

Sorry @Swordfish90,

Unfortunately I upgraded to Android 11 (Syncthing can't sync Android/Data subdirectories) and wiped the saves (due to them not working post use on desktop).

I'll try to create one for you to gander at ASAP.

nullbasis commented 3 years ago

Same problem here, except that the .SAV file was created in MGBA on my desktop. Same issue, though, where Lemuroid isn't detecting it. Here's the file, if it would be helpful.

Swordfish90 commented 3 years ago

Thank you @nullbasis . I was indeed able to replicate the issue on Final Fantasy VI. It looks like the mGBA core can create saves which are smaller than the exposed SRAM size, and Lemuroid was simply discarding them. The fix is ready and will be included in 1.9.0.

DuendeInexistente commented 1 month ago

Hey, coming from the future, having the same issue now. It's a save for the latest version of the Pokemon Unbound romhack, mgba 1.10.2 and lemuroid 1.16.0. Lemuroid seems to be discarding the save offhand when it sees it. 04 14 doecomic.zip