Swordfish90 / Lemuroid

All in one emulator on Android!
GNU General Public License v3.0
2.69k stars 166 forks source link

RTC doesn't work in GBC games and ingame saves only works with a trick #317

Open ghost opened 3 years ago

ghost commented 3 years ago

I have been trying my hack on your emulator today, quick save option works as intended but when I try to use ingame save option it doesn't work, as soon as I restart lemuroid ingame save (SRM file) disappears because it doesn't create a save file for some reason. But if I use ingame hotkeys (A+B+Select+Start) to restart the game it sees my recent save file.

To prevent this right after saving my game I opened lemuroid's menu and pressed quit from there, after that I closed the application and when I open it again I was able to use my save file. I saw a couple people having the same issue on a Discord server so decided to post it here, maybe you can find a solution for it.

Update: RTC is not working in Game Boy Color games, other supported platforms are working fine.

Update 2: Issues persists in 1.12.0.

Update 3: Following image is the RTC test results from ax6's RTC test rom. rtc_test

Platform: Android 11 Version: Lemuroid 1.11.1 and 1.12.0 Game: Personal rom hack but I also tested with non-edited games.

mid-kid commented 3 years ago

Game: Pokemon Crystal

Just posting it synce this is really the only RTC-enabled game people are mostly interested in, and what this issue was reported with.

The RTC test results are mostly irrelevant, and relate more to the gambatte core being used by retroarch. Saving the RTC values is the issue here. EDIT: Yeah, just tested, the RTC test results are similar on other gambatte builds.

mid-kid commented 3 years ago

I wonder if running the mGBA core for GB/C games would help any. While I realize mGBA isn't as accurate when it comes to GB/C, it's updated more frequently and as such more likely to reproduce correct behavior in the long run. Alternatively, the SameBoy core is also available for android.

ghost commented 3 years ago

@Swordfish90 Would you consider giving a shot to mGBA or SameBoy cores? If I remember right SameBoy is more accurate than Gambatte.