Swordfish90 / Lemuroid

All in one emulator on Android!
GNU General Public License v3.0
2.4k stars 153 forks source link

[Proposal] Add Github workflow for releasing #687

Closed mcatta closed 1 year ago

mcatta commented 1 year ago

Context

I see that each release is tagged and the APK is attached to the GitHub release, but I don't see any automation for this flow, I suppose it's manual.

Proposal

Given that there are some Github actions on the market like https://github.com/marketplace/actions/automatic-releases I would propose a new workflow with these parameters:

Trigger

Requirements

Given that the script will build the APK with buildType: release we should persist the keystore and password inside the Github secrets, we can use GPG to increase the security.

Extra

If needed we could run the test suits before the build if needed.

I did it for my personal projects, I can take ownership of the task.

Swordfish90 commented 1 year ago

Hi @mcatta . What a pleasure seeing you here! 😄 ... That's something I've been wanting to do for a very long time so feel free to take it, and thank you very much for your help!

As you guessed, currently all builds are handmade, and for each tag on the release branch (which is basically master with the crowdin translations merged in).

Currently the playstore version is not published on github, and I think it should still be the case so let's just keep here the de-googled variants:

./gradlew assembleFreeRelease

mcatta commented 1 year ago

The PR is ready: https://github.com/Swordfish90/Lemuroid/pull/689 there are a couple of action items

mcatta commented 1 year ago

I close the issue given that PR is merged