Swordfish90 / cool-retro-term

A good looking terminal emulator which mimics the old cathode display...
22.33k stars 850 forks source link

make install DESTDIR=%xy ignored #108

Closed KAMiKAZOW closed 10 years ago

KAMiKAZOW commented 10 years ago

I'm not exactly sure what is going on and why (C.R.T. is one of the tools I learn to package :) ) but despite overriding the default installation directory in line 84 of https://build.opensuse.org/package/view_file/home:KAMiKAZOW:Fedora/cool-retro-term/cool-retro-term.spec?expand=1 the package preparation procedure still tries to create the directory '/usr/lib64/qt5/qml/org'.

See https://build.opensuse.org/package/live_build_log/home:KAMiKAZOW:Fedora/cool-retro-term/Fedora_20/x86_64

Swordfish90 commented 10 years ago

A similar issues was opened a couple of days ago. #106 . It seems that qmake doesn't support make install DESTDIR. I'm definitely not an expert in Qt packaging but Qt looks for QML plugins in a specific system directory that can be read in qmake with $$QT_INSTALL_QML. Anyway I think you can override that variable with qmake INSTALL_DIR=/whatever/something . If you have any suggestion on how to ease packaging I'm all ears.

KAMiKAZOW commented 10 years ago

cmake :)

KAMiKAZOW commented 10 years ago

OBS is currently building. Looks good so far.

Swordfish90 commented 10 years ago

No, please cmake no... :D ... I'm not against it but I just rewrore everything ... :D ... Anyway thank you for all your packaging!

KAMiKAZOW commented 10 years ago

qmake works fine now. After I removed all workarounds that were required earlier, the spec file looks rather clean. I still have to remove all the lines I commented out and write a short changelog. Expect a pull request later today or tomorrow.