search

Swordfish90 / cool-retro-term

A good looking terminal emulator which mimics the old cathode display...
21.84k stars 835 forks source link

Feature/appimage in GitHub actions #711

Closed razziel89 closed 2 years ago

razziel89 commented 2 years ago

Hi @Swordfish90, this is my attempt at creating an appimage via a GitHib workflow (see #698). I've attempted to use the distribution's own QT installation but couldn't figure out how to make it work as I don't know much about QT and appimages, which is why I took that part from the travis config file.

The workflow in this PR successfully built an appimage for me (see here for example releases) whenever a tag is pushed to the repo. The tag's name is then used as name for the release and as version of the appimage.

What do you think? Please let me know if you have any question! One more remark: I've replaced the outdated Ubuntu 14.04 by the current oldest long-term release 18.04 as base image for the appimage build. I've also used specific actions where possible.

Small side note: the only thing keeping me from using this all the time is #676. If you can provide any pointer or hints for where I could look for implementing a fix, those would be highly appreciated!

Swordfish90 commented 2 years ago

Looks very good. Thank you very much @razziel89 for this PR.

Regarding the issue I'll take a look into that next week and I'll see if I can come up with something.

razziel89 commented 2 years ago

Looks very good. Thank you very much @razziel89 for this PR.

Regarding the issue I'll take a look into that next week and I'll see if I can come up with something.

Thank you!