Fix background in settings window

Swordfish90 / cool-retro-term

A good looking terminal emulator which mimics the old cathode display...

21.84k stars 835 forks source link

Fix background in settings window #722

Open EricKotato opened 2 years ago

EricKotato commented 2 years ago

Fixes #428, fixes #612, fixes #689

Settings window text is unreadable in dark themes because background is white on any theme. This PR fixes the problem. Works with both dark and light themes.

After fix:

EricKotato commented 2 years ago

Whoops, looks like renaming the branch closes the PR. That wasn't intended.

jlederman commented 1 year ago

I'm using the Breeze dark theme with KDE and can confirm this change works as intended.

MrAureliusR commented 1 year ago

This fixes multiple reported issues... it should be merged ASAP! Seems there's not a lot of activity in this repo anymore.

wd5gnr commented 1 year ago

Quick workaround: launch like this:

QT_QUICK_CONTROLS_STYLE=Material cool-retro-term

Ugly, but you can read it. This bug is in a few different places.

tony-pelton commented 1 year ago

fwiw, can confirm, this patch solves the problem described on my KDE desktop.