search

Swrve / swrve-android-sdk

Swrve Android SDK
http://www.swrve.com
Other
10 stars 18 forks source link

14097 font download android #244

Closed dominicmarmionswrve closed 8 years ago

dominicmarmionswrve commented 8 years ago

Added font downloading and using the new cdnPaths. Changed the Type on Atoms from a String to an ENUM.

https://swrvedev.jira.com/browse/SWRVE-14097

dominicmarmionswrve commented 8 years ago

@seaders @Sergio-Mira @adam-govan please

Sergio-Mira commented 8 years ago

🚀 (does it do any SHA1 check? note that if we do I've updated the upload to be companyId-SHA1.extension)

dominicmarmionswrve commented 8 years ago

The sha is checked here https://github.com/Swrve/swrve-android-sdk/blob/14097_font_download_android/SwrveSDKCommon/src/main/java/com/swrve/sdk/SwrveAssetsManagerImp.java#L123

But it assumes the whole value is encrypted, including the companyid and extension, which would be inconsistent with server. Lets chat about this.....