Closed ZachAR3 closed 11 months ago
@ZachAR3 Looks good and your changes work for me. You can safely remove :
PYTHON_DIR=$(pwd)/python SCRIPTS_DIR=${PYTHON_DIR}/bin LIB_DIR=${PYTHON_DIR}/lib/"python3.10"/site-packages PIP_PY=$(pwd)/get-pip.py
Also, I like the idea of the initial text you added, I would suggest to reword it like this
echo -e "This program is officially supported only on Arch and Debian-based distributions. The script will install the following dependencies for you: \n[python3-venv, python3-pip, python3-opencv, imagemagick, ffmpeg, jupyter-notebook]\nIf you'd like to proceed with the installation, enter 'Y'. \nPress any other key to exit the installer."
To let folks know that the script will be doing the dependency installation.
Other than that, it works great.
@dsalvat1 Alright thanks. Just added the changes and opened it up to be merged.
I have added basic Arch compatibility' + the option for other distros to use this script at their own discretion if they have already installed the required dependencies. The only thing that could be an issue on other distros are the unused lines at the end which get added to the linux runner script. Specifically these:
As on Arch python isn't installed into the home directory so none of these will work. However, they aren't actually used anywhere from what I could tell and seem to be remnants of an older script I'm assuming? Anyways, once this is addressed I will mark this as a standard PR so it can be merged.