search

Sybio / ImageWorkshop

ImageWorkshop is a PHP5.3+ library that helps you to manage images based on GD library
http://phpimageworkshop.com/
Other
861 stars 189 forks source link

Fix PHP8 #132

Closed loogaroo closed 3 years ago

loogaroo commented 3 years ago

Fix for PHP8

Q A
Bug fix? yes
New feature? no
Fixed tickets
License MIT
loogaroo commented 3 years ago

This seems to fix a PHP 8 issue

jdecool commented 3 years ago

Hi @loogaroo,

Thanks for submitting your PR 👍

Tests are broken, can you fix them and add PHP 8.0 to the test matrix ?

loogaroo commented 3 years ago

@jdecool It should be ok now

loogaroo commented 3 years ago

ok for me

jdecool commented 3 years ago

Just few changes and we will merge this PR :+1:

jdecool commented 3 years ago

Hey @loogaroo, could you fix feedback issues please ?

loogaroo commented 3 years ago

ok sorry for the delay job done !

jdecool commented 3 years ago

PHP 8 compatibility is now supported since 2.2.0 version