search

SydMontague / DSCSTools

Modding tools for Digimon Story: Cyber Sleuth
BSD 3-Clause "New" or "Revised" License
38 stars 9 forks source link

Add new json structures #4

Closed Pherakki closed 3 years ago

Pherakki commented 4 years ago

Adds new json structures:

Also applies "evolution_next_para" to "degeneration_para", since this appears to be the devolution paths.

I can split this up if you want - I just didn't want to spam you with six PRs. I've also started documenting how the game interprets some of the types and switches (e.g. in evolution_condition.mbe) if there is a place to put this information. I plan to help add some more structures in the future, so if there are any guidelines for e.g. formatting and field names you want contributors to follow, please let me know!

SydMontague commented 3 years ago

Oh wow, great to see that more people working on this game. :)

I think combining the structure files in on PR are fine, they're rather simple files anyways. Regarding documentation I'll add a /docs/structures folder after I merged the PR with the stuff I've written down so far (and probably some more structures). Not exactly the most elegant solution IMO, but I think it will do for now.

I haven't really though about style guidelines yet. I'm generally trying to use short camelCase names, so that the header doesn't get too long as well as 2-spaces indentation. So, right now I don't think it's necessary to enforce anything.