search

SydMontague / ImageMaps

draw images on maps
MIT License
44 stars 28 forks source link

Implemented glowing item frames #39

Closed DerEnderKeks closed 3 years ago

DerEnderKeks commented 3 years ago

I also auto formatted everything to get rid of the lines that only contained spaces..

SydMontague commented 3 years ago

Please don't autoformat, it makes it very hard to read the diffs.

DerEnderKeks commented 3 years ago

I split it up into 2 commits for that reason, seems easy enough to read to me.

SydMontague commented 3 years ago

The problem is that I still have to look over it and that my own autoformatter will revert these changes anyways. It also touches more files than necessary, making merge issues more likely.

Anyways, nonetheless good work and thanks for the PR, I appreciate it. :)

DerEnderKeks commented 3 years ago

Thanks :D

Just curious: What IDE are you using and why does it leave spaces at the end of lines? :P

SydMontague commented 3 years ago

I use Eclipse and I probably set it this way to not get thrown back to start of lines when navigating through the code—for empty lines that is, for trailing spaces I probably just forgot pressing the autoformatter. :S