search

Sydokiddo / auditory

A mod that expands and improves upon the sound and audio aspects of Minecraft!
40 stars 13 forks source link

[1.19.2] Lack of null check for itemStack in SpawnEggUseSoundMixin. #54

Open bconlon1 opened 9 months ago

bconlon1 commented 9 months ago

This issue was originally opened on The Aether's repository here: https://github.com/The-Aether-Team/The-Aether/issues/1831.

Essentially, it seems Auditory is missing a check for itemStack != null before calling itemStack.getItem() in this mixin method. The issue with this is that in the original EntityType#spawn() method, itemStack is marked as @Nullable, meaning its not always expected to be non-null. So, Auditory crashes if null is passed by another mod into this parameter.

Sydokiddo commented 8 months ago

Will be fixed in Auditory's rewrite!