search

Syed-Waleed-Shah / rename_app

A flutter package to easily rename your app display name
MIT License
15 stars 5 forks source link

CFBundleName not updating correctly in iOS with rename_app 1.6.1 #10

Open dipu0 opened 1 month ago

dipu0 commented 1 month ago

Here’s the revised issue report without using "when using":

Issue: CFBundleName not updating correctly in iOS with rename_app 1.6.1

Description

I am facing an issue with rename_app version 1.6.1. The CFBundleName in the Info.plist does not update as expected. It seems to retain the old name after running the command.

Steps to Reproduce

  1. Run the following command to rename the app: 
    dart run rename_app:main all="myApp"
  2. The CFBundleDisplayName in the Info.plist updates, but the CFBundleName remains unchanged.
  3. Manually updating CFBundleName works, but running the rename command again restores the old name.

Expected Behavior

Both CFBundleDisplayName and CFBundleName should be updated to the new app name.

Actual Behavior

Only CFBundleDisplayName is updated. CFBundleName retains the old value or reverts when the command is run again.

Environment

Additional Information

Manually changing CFBundleName works temporarily but is overwritten after running the rename command again. It would be helpful if the package also updated CFBundleName as part of the rename process.

flutter doctor

Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.24.1, on Ubuntu 24.04.1 LTS 6.8.0-45-generic, locale en_US.UTF-8) [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) [✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome) ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable. [✓] Linux toolchain - develop for Linux desktop [✓] Android Studio (version 2024.1) [✓] VS Code (version 1.93.1) [✓] Connected device (2 available) [✓] Network resources

! Doctor found issues in 1 category.

Let me know if this works!

Syed-Waleed-Shah commented 1 month ago

Usually CFBundleDisplayName is being used as app label/displayname in IOS. Can you please tell me what is the usage of CFBundleName ? Whether it is being used as app label/displayname in any special case?

dipu0 commented 1 month ago

Usually CFBundleDisplayName is being used as app label/displayname in IOS. Can you please tell me what is the usage of CFBundleName ? Whether it is being used as app label/displayname in any special case?

When app used Google Signin it requests a permission, there it showed app named referred from CFBundleDisplayName, also in web index -> tag did not renamed</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Syed-Waleed-Shah"><img src="https://avatars.githubusercontent.com/u/55924255?v=4" />Syed-Waleed-Shah</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <blockquote> <blockquote> <p>Usually <code>CFBundleDisplayName</code> is being used as app label/displayname in IOS. Can you please tell me what is the usage of <code>CFBundleName</code> ? Whether it is being used as app label/displayname in any special case?</p> </blockquote> <p>When app used Google Signin it requests a permission, there it showed app named referred from CFBundleDisplayName, also in web index -> <title> tag did not renamed</p> </blockquote> <p>Ok, I will look into it and fix the issue as soon as possible. Thanks.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>