search

Syed-Waleed-Shah / rename_app

A flutter package to easily rename your app display name
MIT License
15 stars 5 forks source link

Renaming Does Not Work on Windows #6

Closed Finnomator closed 4 months ago

Finnomator commented 4 months ago

According to this, not windows/CMakeLists.txt but windows/runner/main.cpp has to be changed in order to rename the app on Windows.

Also, changing the BINARY_NAME in windows/CmakeLists.txt causes the following build issue to occur:

Building Windows application...
CMake Error at runner/CMakeLists.txt:9 (add_executable):
  The target name "X X X" is reserved or not valid for certain
  CMake features, such as generator expressions, and may result in undefined
  behavior.

CMake Error at CMakeLists.txt:41 (target_compile_features):
  Cannot specify compile features for target "X X X" which is not
  built by this project.
Call Stack (most recent call first):
  runner/CMakeLists.txt:21 (apply_standard_settings)

.
.
.

Error: Unable to generate build files
Syed-Waleed-Shah commented 4 months ago

According to this, not windows/CMakeLists.txt but windows/runner/main.cpp has to be changed in order to rename the app on Windows.

Also, changing the BINARY_NAME in windows/CmakeLists.txt causes the following build issue to occur:

Building Windows application...
CMake Error at runner/CMakeLists.txt:9 (add_executable):
  The target name "X X X" is reserved or not valid for certain
  CMake features, such as generator expressions, and may result in undefined
  behavior.

CMake Error at CMakeLists.txt:41 (target_compile_features):
  Cannot specify compile features for target "X X X" which is not
  built by this project.
Call Stack (most recent call first):
  runner/CMakeLists.txt:21 (apply_standard_settings)

.
.
.

Error: Unable to generate build files

Ok, I will look into this issue ASAP.

Finnomator commented 4 months ago

@Syed-Waleed-Shah if you are currently not working on this I can fix it.

Syed-Waleed-Shah commented 4 months ago

@Syed-Waleed-Shah if you are currently not working on this I can fix it.

It would be appreciated if you could fix this :) @Finnomator