search

SyfSchydea / pokeclicker-automation

Automates various aspects of the game Pokéclicker
1 stars 0 forks source link

Quest starts a quest for an uncompleted gym, but doesn't complete it #19

Closed SyfSchydea closed 1 year ago

SyfSchydea commented 1 year ago

The script is written to not try to complete any gyms which haven't been completed before. But it will still start a gym quest for a gym which hasn't been completed before.

(tangential ramblings not really to do with this bug but,) I could maybe add a setting to allow the script to go for routes/gyms/dungeons which haven't been cleared before...

SyfSchydea commented 1 year ago

So I raised this bug in response to the script accepting a quest for a gym which I hadn't yet completed (and didn't want to yet). I've flipped the check which I think made that happen, but having that that's what caused it, I'm not really sure how it ever worked for any gyms in the past...

We'll see how it works in testing later I guess...

SyfSchydea commented 1 year ago

I can confirm that it at least isn't starting the quest it shouldn't anymore. I want to test that valid gym quests do actually get completed properly still before I merge to master.

SyfSchydea commented 1 year ago

Confirmed. It works, but I'm still not sure how it was working before.

Ready to merge.