Sygil-Dev / stable-diffusion

GNU Affero General Public License v3.0
1.72k stars 148 forks source link

Two repositories makes it harder to look at diffs and view changes. #193

Closed muchcharles closed 2 years ago

muchcharles commented 2 years ago

Could it make sense to use a development branch instead of the separate webui repository? Two repositories makes it harder to look at diffs and use git tools for searching changelogs, blaming files etc.

JoshuaKimsey commented 2 years ago

Well, I think the main point of having the two repos is that one is the stable branch containing the full Stable Diffusion code and the WebUI code, pulled over at specific periods when things are known to be working. The other repo is just for the WebUI code development primarily.

It could be done in one repo, with multiple branches. But, that would make it harder for people to separate out what issues they have, Sd itself vs the WebUI code for example. It's possible once the project reaches a true Release point that the two could be merged and start using different branches. But that will be up to hlky and the others to decide that.

rinukkusu commented 2 years ago

@JoshuaKimsey I understand where you're coming from, but since the whole development mostly is done in the webui parts anyway, I don't see that much of a profit having two repos.

Just go back the last 7 days of commits - it's 95% syncing files from the webui repo 😺

rinukkusu commented 2 years ago

Heh, okay