Sygil-Dev / stable-diffusion

GNU Affero General Public License v3.0
1.72k stars 149 forks source link

Renamed Docker container to sd-hlky to a avoid common abbreviation #242

Closed ChrisAcrobat closed 2 years ago

ChrisAcrobat commented 2 years ago

~⚠️ Contains unmerged changes from PR #241.~ @oc013: Is this considered a breaking change? 2e80f9ddae527c856e4c11f97879dc2f1f096069

ChrisAcrobat commented 2 years ago

I'll keep this PR as a draft until I get confirmation that this isn't a breaking change. @oc013 or someone else with more Docker experience than me, please confirm.

oc013 commented 2 years ago

I think it's fine, I did a quick test here and even without removing the old container it was renamed and used the existing images and volumes even while the container was running under the old name.

$ docker compose version
Docker Compose version v2.6.0

Hopefully all versions of docker compose behave the same, but I am guessing most problems could be resolved with running

docker stop sd
docker rm sd
ChrisAcrobat commented 2 years ago

I did the same check and it was fine for me to. Just wanted a double check. 👍