Closed stumpylog closed 7 months ago
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ad3dd47
) 98.55% compared to head (ae5d7e0
) 80.92%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Wow, thanks for the PR @stumpylog, really appreciate it. Merging the PR in a minute.
@stumpylog I have a question, do you happen to know by any chance how to get the bot to show the grid coverage like this? https://github.com/whoosh-community/whoosh/pull/548#issuecomment-517777183
Not offhand, but probably it's described here: https://docs.codecov.com/docs/pull-request-comments
Little hard to see it from my phone
I see, tomorrow I will take a better look at the docs you linked and see if I can find how to do that since it's useful to have that on the bot when it comments on a PR. I'm about to sleep in a bit so I'm also on my phone right now. I plan to add as many tests as I can tomorrow to increase the tests coverage and see if I can also make the sonarcloud.io github action pass,the tests will probably be mostly AI generated but it's better than nothing at all, as long as they cover many different scenarios I think it will be okay, we can always improve them later.
Description
This resolves the code coverage reporting, so the actual source files will also have coverage reported. I configured my own fork with a token and you can view the results: https://app.codecov.io/github/stumpylog/whoosh-reloaded
The main fix is to install using
pip install -e .
or editable. Otherwise, coverage was not picked up those files are being relvant.The other small fix was to only run the testing once.
Closes: #48
Checklist: