Sygil-Dev / whoosh-reloaded

Whoosh is a fast, featureful full-text indexing and searching library implemented in pure Python.
https://sygil-dev.github.io/whoosh-reloaded/
Other
91 stars 13 forks source link

Fix: Resolve the Codecov reporting #58

Closed stumpylog closed 7 months ago

stumpylog commented 7 months ago

Description

This resolves the code coverage reporting, so the actual source files will also have coverage reported. I configured my own fork with a token and you can view the results: https://app.codecov.io/github/stumpylog/whoosh-reloaded

The main fix is to install using pip install -e . or editable. Otherwise, coverage was not picked up those files are being relvant.

The other small fix was to only run the testing once.

Closes: #48

Checklist:

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ad3dd47) 98.55% compared to head (ae5d7e0) 80.92%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## =========================================== - Coverage 98.55% 80.92% -17.64% =========================================== Files 34 133 +99 Lines 9839 29410 +19571 Branches 1318 5053 +3735 =========================================== + Hits 9697 23799 +14102 - Misses 122 4742 +4620 - Partials 20 869 +849 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ZeroCool940711 commented 7 months ago

Wow, thanks for the PR @stumpylog, really appreciate it. Merging the PR in a minute.

ZeroCool940711 commented 7 months ago

@stumpylog I have a question, do you happen to know by any chance how to get the bot to show the grid coverage like this? https://github.com/whoosh-community/whoosh/pull/548#issuecomment-517777183

stumpylog commented 7 months ago

Not offhand, but probably it's described here: https://docs.codecov.com/docs/pull-request-comments

Little hard to see it from my phone

ZeroCool940711 commented 7 months ago

I see, tomorrow I will take a better look at the docs you linked and see if I can find how to do that since it's useful to have that on the bot when it comments on a PR. I'm about to sleep in a bit so I'm also on my phone right now. I plan to add as many tests as I can tomorrow to increase the tests coverage and see if I can also make the sonarcloud.io github action pass,the tests will probably be mostly AI generated but it's better than nothing at all, as long as they cover many different scenarios I think it will be okay, we can always improve them later.