Syiana / SUI

SUI - The Dark Side of World of Warcraft
https://www.curseforge.com/wow/addons/sui
38 stars 16 forks source link

Issue when mouse over on new players character (enabled by being a guide) #51

Closed rfreiberger closed 1 year ago

rfreiberger commented 1 year ago

Describe the bug There is an exception created when mouse over on any character that has the new player icon enabled. This is only viewable if you enable the "guide" function and you can view the murloc icon above their heads.

To Reproduce Steps to reproduce the behavior:

  1. Enable the guide function (for Alliance, you talk to Celeste Periwinkle)
  2. Confirm you see the murloc icons above new players
  3. Mouse over any new player
  4. Error should pop up with attempt to concatenate field '?' message

Expected behavior The mouse over should work with new players as it works with existing players.

Screenshots WoWScrnShot_112622_195702

Which World of Warcraft version (please complete the following information):

Additional context I can add screenshots and discuss on Discord if needed, please feel free to reach out.

rfreiberger commented 1 year ago

Adding the error output.

Message: Interface/AddOns/SUI/Modules/Tooltip/_Core.lua:85: attempt to concatenate field '?' (a nil value)
Time: Sat Nov 26 19:46:41 2022
Count: 4
Stack: Interface/AddOns/SUI/Modules/Tooltip/_Core.lua:85: attempt to concatenate field '?' (a nil value)
[string "@Interface/AddOns/SUI/Modules/Tooltip/_Core.lua"]:85: in function <Interface/AddOns/SUI/Modules/Tooltip/_Core.lua:66>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `securecallfunction'
[string "@Interface/SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <Interface/SharedXML/Tooltip/TooltipDataHandler.lua:55>
[string "@Interface/SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <Interface/SharedXML/Tooltip/TooltipDataHandler.lua:76>
[string "@Interface/SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <Interface/SharedXML/Tooltip/TooltipDataHandler.lua:106>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface/SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <Interface/SharedXML/Tooltip/TooltipDataHandler.lua:134>
[string "@Interface/SharedXML/Tooltip/TooltipDataHandler.lua"]:282: in function <Interface/SharedXML/Tooltip/TooltipDataHandler.lua:240>
[string "=[C]"]: in function `securecallfunction'
[string "@Interface/SharedXML/Tooltip/TooltipDataHandler.lua"]:237: in function `ProcessInfo'
[string "@Interface/FrameXML/GameTooltip.lua"]:970: in function `SetWorldCursor'
[string "@Interface/FrameXML/UIParent.lua"]:1439: in function <Interface/FrameXML/UIParent.lua:1362>

Locals: self = GameTooltip {
 0 = <userdata>
 SetQuestLogRewardSpell = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 ItemTooltip = Frame {
 }
 SetHyperlink = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetAzeriteEssence = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetVoidDepositItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetTraitEntry = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 ClearBackdrop = <function> defined @Interface/SharedXML/Backdrop.lua:282
 SetLootCurrency = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetWorldCursor = <function> defined @Interface/FrameXML/GameTooltip.lua:952
 SetLootItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 GetSpell = <function> defined @Interface/FrameXML/GameTooltip.lua:990
 SetQuestLogSpecialItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetRecipeReagentItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetMerchantItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 BottomOverlay = Texture {
 }
 SetSocketedRelic = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 ProcessInfo = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:236
 NineSlice = Frame {
 }
 OnLoad = <function> defined @Interface/FrameXML/GameTooltip.lua:927
 TopEdge = Texture {
 }
 SetUnitDebuffByAuraInstanceID = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetBagItem = <function> defined =[C]:-1
 SetBackdropColor = <function> defined @Interface/SharedXML/Backdrop.lua:399
 LeftEdge = Texture {
 }
 AddLineDataText = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:324
 SetSpellBookItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 textLeft1Font = "GameTooltipHeaderText"
 SetShapeshift = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetArtifactPowerByID = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 textRight2Font = "GameTooltipText"
 TopOverlay = Texture {
 }
 SetSocketedItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetUnitDebuff = <function> defined =[C]:-1
 SetMountBySpellID = <function> defined
rfreiberger commented 1 year ago

I'm seeing the same issue after updating to SUI version 10.0.33.

IskrenTs commented 1 year ago

My fix is not approved yet. Since i am not part of the dev team and just a side person they need to review my code and then to approve it.

muleyo commented 1 year ago

Thanks for reminding me. Totally forgot about it!

muleyo commented 1 year ago

Update has been pushed and will be available shortly.

Thanks again @IskrenTs