search

SylEleuth / gruvbox-plus-icon-pack

Gruvbox Plus icon pack for Linux desktops based on Gruvbox color theme.
GNU General Public License v3.0
323 stars 16 forks source link

Icon Request - Merkuro Calendar #43

Closed mercifulboss closed 6 months ago

mercifulboss commented 6 months ago

Can you please add a icon for Merkuro Calenar (as well as mail and contacts)?

image

This is an official KDE app currently under development

https://github.com/KDE/merkuro

https://apps.kde.org/merkuro.calendar/

SylEleuth commented 6 months ago

https://github.com/SylEleuth/gruvbox-plus-icon-pack/commit/24f980c0ccd342039007fce1a9a06bc6dae654b3

Links provided by You do not have icons for Merkuro apps (calendar, contact, mail), only for Kalendar, which is going to be replaced by those apps. Unfortunately I cannot test it at the moment. Can You do that and tell me if they display properly?

mercifulboss commented 6 months ago

Hello, thanks for doing this so rapidly.

It seems to work, but for some reason the color is not maintained in the taskbar with some icons being white and others yellow:

image

It seems the larger icons work as well

merkuro

SylEleuth commented 6 months ago

That will be hard to find a culprit. First thing I can think of is the old formatting. Let's test it on a new calendar icon. I've just pushed it to repo. It's only one icon but it will give me so direction where to go with that. Could You pull it and test it?

What's the app behind "H" icon? Is a "bulb" a "night colors" from kde settings?

mercifulboss commented 6 months ago

It worked. I had to switch to another theme and then switch back and it updated:

image

The 'H' is the icon for Optimus Manager Hybrid mode (to select between using either dedicated GPU, both GPU and integrated graphs or just integrated graphics), its for hybrid nvidia laptops:

Gruvbox theme

Edit: The bulb is the night light for wayland, i always have it on as its easier on my eyes. Gruvbox icon theme 2

SylEleuth commented 6 months ago

So I believe I found and corrected every each icon on Your task bar. Especially "bulb" icon, which is a new one (and terminal, and wifi). I'm currently working on "apps" folder and some of those changes are temporary until I finish and merge them properly so sizes might be off a little bit. And I can't test "Optimus manager" because I'm on the AMD but it should be fine now. Let me know how it looks and I will make additional changes if necessary.

mercifulboss commented 6 months ago

Thank you for taking the time!

It looks great!😍

For some reason however, Firefox and optimus manager do not update properly:

image

Also, it seems that when new apps are opened they still follow the old theme. Not sure what I am doing wrong:

image

Those are the libre-office and spectacle apps

In addition I noticed that other entries in the application menu are white. Not sure if I am doing something wrong or its supposed to be that way but I thought i'd point it out: gruvbox icons plus application menu

SylEleuth commented 6 months ago
  1. Saying that I "corrected every each icon" was of course wrong because I forgot to add firefox and somehow I missed spectacle (screenshot icon). I've just added them.
  2. I've also made some mistakes with hybrid icon. Please tell me how it looks now.
  3. You are not doing anything wrong. Apps icons are not formatted properly and require a lot of work (because there are thousands of them). As I said previously I'm on it right now but there are other icons in my queue. On the request I will add missing icons or modify broken ones, but at the moment I can't add all "apps" folder with partially fixed icons.
  4. Are all icons in the application menu are white? I've pushed libreoffice icon so it should display with the right colour. If that is correct and other icons are white please see point 3. In the meantime You could override that buy changing general system colours manually in the Plasma settings (Plasma 5, I'm not in Plasma 6 yet), go Appearances/Colours and choose edit colour scheme. Find the window text colour and change it to #ebdbb2. Eventually You could download and use my own scheme. If you prefer to not modify anything and stay with Your colour the only option is to wait until I finish modifying the apps icons.
mercifulboss commented 6 months ago

Thank you very much for taking the time!

  1. Everything looks great! I especially like the new dolphin icon 😍. Spectacle also works and looks great!
  2. The hybrid icon still doesn't seem to work: image
  3. Makes sense. Thanks alot for doing this.
  4. Libreoffice works but the rest are white: gruvbox icons application menu partially updated

Thanks, I was able to successfully change color schemes! I am not sure what to do with dotfiles so I didn't change that.

SylEleuth commented 6 months ago

I made (another) mistake and linked the wrong dolphin icon. The one You see is for dolphin emulator app. I fixed it. Probably it will be disappointing in comparison. But there is a different problem - why it displays 16px size icon and not full (scalable) one? Can You tell me what You see now? Can You look at the file in /usr/share/applications/org.kde.dolphin.desktop and give me the icon= name?

Color scheme folder is located in ~/.local/share/color-schemes where You can copy the file.

Still don't know what is going on with hybrid icon. It will take more time to figure it out.

mercifulboss commented 6 months ago

Here is what I see after updating: image

/usr/share/applications/org.kde.dolphin.desktop

Going to this path only takes me back to the gruvbox-icon-plus folder since I made it as a symlink so I can git pull. I don't see any option for a icon =. Where should I look to find it?

Color scheme folder is located in ~/.local/share/color-schemes where You can copy the file.

Thanks! I found it.

Still don't know what is going on with hybrid icon. It will take more time to figure it out.

To me it sounds like the app overrides its icon, but i'm not sure. not an expert.

SylEleuth commented 6 months ago

Going to this path only takes me back to the gruvbox-icon-plus How it's even possible? That's a system folder responsible for all applications.

Could you show me apps launcher where dolphin icon is visible? Not task bar.

mercifulboss commented 6 months ago

Going to this path only takes me back to the gruvbox-icon-plus How it's even possible? That's a system folder responsible for all applications.

Could you show me apps launcher where dolphin icon is visible? Not task bar.

I recorded a short video to demonstrate:

Screencast_20240311_105054.webm

Here is dolphin in application launcher. If that is what you mean:

gruvbox icon themes dolphin app launcher

SylEleuth commented 6 months ago

Do not try to open that file straight from the path bar. Go to folder /usr/share/applications first and tell me if there is a file named org.kde.dolphin.desktop. If You can't find it there, go to ~/.local/share/applications next and check there.

mercifulboss commented 6 months ago

Do not try to open that file straight from the path bar. Go to folder /usr/share/applications first and tell me if there is a file named org.kde.dolphin.desktop. If You can't find it there, go to ~/.local/share/applications next and check there.

The folder is right there:

image

SylEleuth commented 6 months ago

I'm closing it for now. If You'll find something broken please open a new issue.

Thank You for the contribution.