search

Sylake / AkeneoProducerBundle

[DEPRECATED] Produces messages consumed by Sylake/SyliusConsumerBundle.
MIT License
30 stars 16 forks source link

Validation error on creating job #39

Closed rmikalkenas closed 7 years ago

rmikalkenas commented 7 years ago

I get locale validation error when trying to create a job. My locale is en_US, but en_GB and de_de are hardcoded in Sylake\AkeneoProducerBundle\Connector\JobParameters\AkeneoProducer (https://github.com/Sylake/AkeneoProducerBundle/blob/master/src/Connector/JobParameters/AkeneoProducer.php#L53). I think locales setting should be set from active system locales or made configurable

$ app/console akeneo:batch:create-job "Sylake - Akeneo Producer" sylake_akeneo_producer export sylake_akeneo_producer

A validation error occurred with the job configuration "

  • Array[filters][structure][locales][0]: The locale en_GB is not valid.
  • Array[filters][structure][locales][1]: The locale de_DE is not valid.".
pamil commented 7 years ago

@rokasmi are you willing to create a PR adding this configuration option?

rmikalkenas commented 7 years ago

Opened pull request, please review. BTW, for the future, I think rabbitMQ configuration should be configurable too. What if I need multiple producers, so that different consumers could consume same changes

pamil commented 7 years ago

v1.0.0-beta.2 released with your PR. 🎉