Sylake / SyliusConsumerPlugin

[DEPRECATED] Consumes messages produced by Sylake/AkeneoProducerBundle.
MIT License
15 stars 6 forks source link

Id attribute missing for top level services #41

Closed 4c0n closed 5 years ago

4c0n commented 5 years ago

Likely due to the changes between Symfony 3 and 4 the service xml files seem to be broken. When running composer install in Sylius, errors occur because of that.

This PR fixes that problem.

If you can think of better id attribute values, please comment so that I can modify them. Needless to say that any other feedback is of course welcome.

4c0n commented 5 years ago

@pamil @Arminek @arnolanglade @lchrusciel Could any of you respond please? Is this repo "abandonware"? If so, please update the README.md to state that you are no longer maintaining this project (I'd gladly make another PR for you to provide that information and save others time and effort looking into/testing this plugin). Also it might be good to request the folks over at Sylius to remove this plugin from their website as now it looks like there is the possibility to connect Sylius with Akeneo out of the box, but really there is no working solution at all (for the newer Symfony/Sylius/Akeneo versions anyway).

4c0n commented 5 years ago

Plugin is discontinued, closing PR. For more info see https://sylius-devs.slack.com/archives/C9GQMG316/p1545393382006300