Find product even if translation does not exist

Sylius / AdminOrderCreationPlugin

Create orders in Sylius as an Administrator

MIT License

55 stars 50 forks source link

Find product even if translation does not exist #128

Closed hmonglee closed 1 year ago

hmonglee commented 5 years ago

When I create an order if products don't have translation in my locale, I can't select a product.

I think we should access to all products even if translation doesn't exist.

Zales0123 commented 5 years ago

Hello @hmonglee and thank you for this improvement. Would you be able to provide a scenario reproducing the problem? We should definitely have it to prevent regression and be 100% sure the fix is working properly :)

hmonglee commented 5 years ago

Scenario :

Connect to the admin panel
Add product with locale "en_gb" translation
Set current user preferences locale to a locale different of "en_gb"
Create an order and try to select the product you just create before

You will not find the product because of the doctrine inner join between product translation locale and current user locale

Zales0123 commented 5 years ago

Thank you, I should be more precise :) Would you be able to create and implement a Behat scenario (and therefore a test) for this bugfix? 🚀

lchrusciel commented 3 years ago