search

Sylius / AdminOrderCreationPlugin

Create orders in Sylius as an Administrator
MIT License
55 stars 50 forks source link

Upgrade to Sylius 1.10 and Symfony >5.2 #170

Closed Roshyo closed 3 years ago

Roshyo commented 3 years ago

Provide support for Sylius 1.10 and Symfony 5.2 or later

Zales0123 commented 3 years ago

Hello @Roshyo! Even though we're not supporting this plugin actively nowadays, this PR is definitely something we would like to have :) I've enabled proper builds and made some changes in dependencies, but it requires a little bit of work to be mergeable. Do you think you would be able to fix it in the nearest future, or should I take it over?

Cheers 🖖

Roshyo commented 3 years ago

Well, since I will be away for the next 3 weeks or so. I would love it if you could take over on that point.

Or it will have to wait until I get back.

pamil commented 3 years ago

Thank you, Stephane! :tada:

aleho commented 3 years ago

The release notes state "Upgrade to Sylius 1.10" but this PR did not bump the allowed Sylius version from 1.9.

This resluts in sylius/admin-order-creation-plugin v0.12.0 requires sylius/sylius 1.9.* -> found sylius/sylius[v1.9.0-RC.1, ..., v1.9.5] but it conflicts with your root composer.json require (1.10.*)..

Has this PR not been tested with Sylius 1.10 or is my composer.json wrong?

pamil commented 3 years ago

@aleho good catch, we've totally missed that!