search

Sylius / InvoicingPlugin

Generate an Invoice for every placed order
MIT License
79 stars 82 forks source link

Shipping Tax #70

Open tomaszfelczyk opened 5 years ago

tomaszfelczyk commented 5 years ago

Shipping Tax is hardcoded to zero.

https://github.com/Sylius/InvoicingPlugin/blob/226e6966b4fbb0fe20bc69b4fdd08d3405410dd0/src/Generator/InvoiceGenerator.php#L104

bartoszpietrzak1994 commented 5 years ago

Hello Tomasz,

Indeed, it's a missing feature. Since we want to spend some time in the nearest future on stabilizing plugins, we will for sure investigate this issue in order to provide the most extensible and functional solution.

tomaszfelczyk commented 5 years ago

Hi @bartoszpietrzak1994 , Thanks for the reply.

  1. In my opinion, this plugin could be more generic and support more than one type of docs with individual sequence numbers (receipts/invoices/credit memos etc.) and templates. This will be really helpful if in future in case of using external cash registers in POS or just in case you generate a simple receipt for each order in the first channel and VAT invoice in another channel (B2B).

  2. In Sylius we already have sequence generator used in OrderBundle. Have you thought about decoupling it to independent Bundle/Plugin with the support of many sequences?

Zales0123 commented 5 years ago

Hello, Tomasz 🖖

  1. You're right, however, we really focus right now on delivering the best basic functionalities, which is also easy to extend or customize - the same purpose, as for Sylius itself :) we will for sure be thinking about additional features after plugin's stable release.
  2. We were thinking about it some time ago, the idea had gone due to lack of time and resources, but, again, I'm sure we will do something with it in the future (hopefully not-so-far :))