search

Sylius / PayPalPlugin

Official integration with PayPal Commerce Platform
37 stars 56 forks source link

Conflict with symplify/package-builder #173

Closed armellarcier closed 3 years ago

armellarcier commented 3 years ago

This packages composer.json marks symplify/package-builder versions "^8.3.24" as conflicting.

With sylius 1.8.5 I get symplify/package-builder version 8.3.48

Sylius/CodingStandard requires "symplify/easy-coding-standard": "^7.3 || ^8.1" (see here)

I can't downgrade symplify/easy-coding-standard to 7.3 because sylius/grid-bundle v1.7.5 conflicts with symplify/smart-file-system v7.3.18

Here is what happens when I composer require sylius/paypal-plugin:

Using version ^1.1 for sylius/paypal-plugin
./composer.json has been updated
Running composer update sylius/paypal-plugin
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires sylius/paypal-plugin ^1.1 -> satisfiable by sylius/paypal-plugin[v1.1.0].
    - symplify/easy-coding-standard 8.3.48 requires symplify/package-builder ^8.3.48 -> satisfiable by symplify/package-builder[8.3.48].
    - sylius-labs/coding-standard v3.2.1 requires symplify/easy-coding-standard ^7.3 || ^8.1 -> satisfiable by symplify/easy-coding-standard[8.3.48].
    - symplify/package-builder 8.3.48 conflicts with sylius/paypal-plugin v1.1.0.
    - sylius-labs/coding-standard is locked to version v3.2.1 and an update of this package was not requested.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

I don't see how I can work around this.

So what is the reason for the conflict being declared in PayPalPlugin's composer.json in the first place?

armellarcier commented 3 years ago

This commit added the conflict directive

https://github.com/Sylius/PayPalPlugin/commit/4bc2449935a401c02cd0664b1fc774dbe90bf853

Zales0123 commented 3 years ago

Hi Armel! As far as I remember, there was some problem regarding this package on the Sylius itself. As I see, it's not conflicted anymore, so we can definitely remove it and see what happens :) Would you like to open a PR with such a change? Thanks! 🖖

armellarcier commented 3 years ago

Done @Zales0123 but I just removed the line

armellarcier commented 3 years ago

@Zales0123 see #174

ehibes commented 3 years ago

I just managed to install sylius/paypal-plugin with sylius 1.8 downgrading it to v1.0.0-RC.1 version. Maybe, il would be necessary to update composer.json ?