add transaction id to payment details

Sylius / PayPalPlugin

Official integration with PayPal Commerce Platform

37 stars 56 forks source link

add transaction id to payment details #252

Closed PILLOWPET closed 2 years ago

PILLOWPET commented 2 years ago

Q	A
Branch?	1.3 (security fixes), 1.4 (bug fixes, improvements), master (new features)
Bug fix?	no
New feature?	yes
Related tickets	mentioned in #251

Zales0123 commented 2 years ago

The base of this pull-request was changed, you need fetch and reset your local branch if you want to add new commits to this pull request. Reset before you pull, else commits may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet, execute git fetch origin && git reset "add-transaction-id-to-payment-details" to update your local branch.

Feel free to ask for assistance when you get stuck :+1:

Zales0123 commented 2 years ago

Hello @PILLOWPET 🖖 I've allowed myself to rebase it and add a basic spec for the new functionality (there was no spec for the class at all 😱 definitely needs to be fixed). I've also added a check if the gathered value is set, to prevent from potential failures.

Thank you for your contribution! 🚀

Zales0123 commented 2 years ago

Thanks, Hadrien! :tada: