search

Sylius / PluginSkeleton

Skeleton for starting Sylius plugins.
https://sylius.com/plugins/
73 stars 63 forks source link

Impossible to create symfony recipe for a plugin created with this skeleton due to payum #183

Open jacquesbh opened 4 years ago

jacquesbh commented 4 years ago

Hi!

Let's keep it simple: https://travis-ci.org/symfony/recipes-contrib/jobs/654942372 This link is the CI testing the recipe for a plugin. The plugin is really simple and requires sylius/sylius=~1.3.

The plugin works well.

But when we want to create a recipe it gives an issue about payum. It should not.

I'm trying to change the way I require sylius in the plugin but I think we may have an issue here.

Is there any chance a core team developer could take a look at it?

Thank you!

Zales0123 commented 4 years ago

Hello Jacques!

The problem with flex recipes for plugins is deeper 🕳 There are no recipes for Sylius extracted bundled (like SyliusResourceBundle) and therefore for Sylius itself as well. As you can see, on the Travis, the test consists of installing a bundle (a Sylius plugin, in this case), on symfony/skeleton application. I don't know if it's related to this, but even if not, there would be some more problems after solving it. Plugins required sylius properly configured, which cannot be done automatically without a recipe for sylius/sylius 😢

We were lucky with our plugins 😄 as recipes for them were created where there was no such a check yet (only symfony flex bot, see this PR). But when we wanted to improve something, a similar thing happened.

For sure we would like to provide some recipes for all our bundles and Sylius itself 🖖 I'll let you know when it's done :)

jacquesbh commented 4 years ago

Let's see how it goes: https://github.com/Payum/PayumBundle/pull/511 Because for now my issue is Payum.

Maybe when Payum is resolved I'll have more problems :p