search

Sylius / RbacPlugin

Sylius roles and permissions management plugin
32 stars 38 forks source link

"UpdateAdministrationRoleViewAction" doesn't check if provided role is found #58

Closed diimpp closed 5 years ago

diimpp commented 5 years ago

https://github.com/Sylius/RbacPlugin/blob/master/src/Action/UpdateAdministrationRoleViewAction.php#L50

Should throw NotFoundException in case it's not there.

Zales0123 commented 5 years ago

Agreed 👍 Are you willing to open a PR with this fix?

diimpp commented 5 years ago

@Zales0123 Yes, I'm currently doing my first integration of the plugin, I can take on the issues, once I will be done.

bartoszpietrzak1994 commented 5 years ago

Hi Dmitri!

Thank you for pointing out this issue and we all appreciate your will to help us with fixing it. However, since we want to stabilize the plugin as fast as possible, I've managed to open a PR with the fix.