search

Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

[Doc] fix `checkoutState` parameter in `PlacedOrder` swagger definition #611

Closed EmilMassey closed 4 years ago

EmilMassey commented 4 years ago

I think the intention here was to display order's state (then the enum would be correct), but in fact checkout state is returned as in Cart definition.

Note that the checkout state will always be completed for placed orders.

EmilMassey commented 4 years ago

I think displaying order's state would be useful for some, though. Do you think we should add it to the view? I could work on implementation in other PR.

mamazu commented 4 years ago

The default state is probably cart for carts and only completed for orders.

mamazu commented 4 years ago

Thanks, Emil! :1st_place_medal: