Add Validation on Customer Gender

Sylius / ShopApiPlugin

Shop API for Sylius.

https://sylius.com

129 stars 89 forks source link

Add Validation on Customer Gender #617

Closed Amr3zzat closed 4 years ago

Amr3zzat commented 4 years ago

Add Validation on Gender field [Update Customer Request] Gender Filed will only accept these letters ['u', 'm', 'f']. related issue #614

mamazu commented 4 years ago

Looks good, so far. If you could fix the tests it would be great. And maybe add a test that tests the validation (so that when the user enters an invalid gender it returns a 400).

Amr3zzat commented 4 years ago

@mamazu I have fixed the old test , add new test for this case

mamazu commented 4 years ago

Thank you, Amr! :tada: