search

Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

Request password reset needs validation #618

Closed Amr3zzat closed 4 years ago

Amr3zzat commented 4 years ago

There are two scenarios: First: Enter empty email Expected: it returns 400 with validation error Actual: it returns 500

Screen Shot 2020-01-01 at 9 13 18 AM

Second: Enter email not exists in users Expected: it returns 400 with validation error Actual: it returns 500

Screen Shot 2020-01-01 at 9 12 42 AM
Amr3zzat commented 4 years ago

I was working in this issue

I have fixed the first part of the issue in my PR

About the second part “User not found” I think it should return 204 in all cases if the user entered a valid email even it doesn’t exists for security considerations, true?