search

Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

Add email validation to RequestResetPassword #621

Closed Amr3zzat closed 4 years ago

Amr3zzat commented 4 years ago

Add email Validation to RequestResetPassword

618

mamazu commented 4 years ago

I have fixed the codestyle in your branch and added the information about the change in behavior in the change logs and rebased it onto the master so the pipeline should be green now.

The base of this pull-request was changed, you need fetch and reset your local branch if you want to add new commits to this pull request. Reset before you pull, else commits may become messed-up. Unless you added new commits (to this branch) locally that you did not push yet, execute git fetch origin && git reset "Add-Reset-password-validation" to update your local branch. Feel free to ask for assistance when you get stuck. :+1:

Amr3zzat commented 4 years ago

@mamazu Thanks for your review I will check them, I have updated my local branch, I got stuck for some time, but It worked thanks

Amr3zzat commented 4 years ago

@mamazu @lchrusciel Thanks for your review, it was so helpful, I have fixed the specs.

mamazu commented 4 years ago

If you can fix the tests then it should be good to go.

Amr3zzat commented 4 years ago

@mamazu Many Thanks for your help, I fixed them

mamazu commented 4 years ago

Thanks, Amr! :1st_place_medal: