search

Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

Use Channel Context instead of getChannel #628

Closed Amr3zzat closed 11 months ago

Amr3zzat commented 4 years ago

Use Channel Context Directly in ViewRepository instead of passing channel code and use getChannel

mamazu commented 4 years ago

@lchrusciel What do you think? I don't know if this has any wider implications.

Amr3zzat commented 4 years ago

@lchrusciel Yes it is the same behaviour, it is just refactor to get the channel directly in the ViewRepository instead of passing the code from the action, I removed the issue mentioned to fix that.

lchrusciel commented 4 years ago

Hey Amr, thanks a lot for your work, but as I said, due to bc breaks in this PR, I cannot merge it.

I hope you understand.