search

Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

Fixing the Checkout state validator. #676

Closed mamazu closed 3 years ago

mamazu commented 4 years ago

Closes #665

mamazu commented 4 years ago

I could add one but I don't know how someone can manage to get the cart into such a state.

lchrusciel commented 4 years ago

We should try to complete cart, which is not addresses/shipment is not selected/payment is not selected

mamazu commented 4 years ago

Valid point I will add that.

mamazu commented 4 years ago

We already have a test for this: https://github.com/Sylius/ShopApiPlugin/blob/master/tests/Controller/Checkout/CompleteOrderApiTest.php#L391

lchrusciel commented 3 years ago

Thanks, @mamazu! :tada: