search

Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

Changing the localeSetter Priority breaks translation in the admin panel #709

Closed bindermuehle closed 3 years ago

bindermuehle commented 3 years ago

https://github.com/Sylius/ShopApiPlugin/pull/703/commits/7b0494a5f09b5473276114fc4a744bd78719dc30

Localization of the admin panel stops working when the priority of RequestLocaleSetter (25) is set higher than the Firewall (8). The firewall sets the security token which is required to get the users locale.

mamazu commented 3 years ago

Which version of Sylius do you use?

lchrusciel commented 3 years ago

This PR should fix the original issue on Sylius: https://github.com/Sylius/Sylius/pull/12458. Once the Sylius/Sylius will be released, we are ready to fix it here

lchrusciel commented 3 years ago

Hey @bindermuehle. It should be fixed already