Sylius / ShopApiPlugin

Shop API for Sylius.
https://sylius.com
129 stars 89 forks source link

Can't be installed with sylius 1.12 #733

Closed avasiliauskas closed 1 year ago

avasiliauskas commented 1 year ago

ShopApiPlugin requires "symfony/messenger": "^4.4|^5.2" but Sylius 1.12 requires "symfony/messenger": "^5.4"

If there is no plans to support Sylius 1.12 version should be stricted to ^1.10.0 in composer.json

diimpp commented 1 year ago

It's just behind on maintenance, there is no big difference between 1.10 and 1.12 aside new api changes.

So if this plugin requires ^5.2 and sylius ^5.4 then messenger 5.4 satisfies both requirements?

^1.10.0 will be the same as ^1.10 as this is stable release and not pre-release

What kind of error you're getting? Are you on messenger 4.4 by any chance?

mamazu commented 1 year ago

Yeah just tried it with 1.13 as well and it works. Maybe you need to install the plugin with some extra composer flags:

composer require sylius/shop-api-plugin --update-with-all-dependencies 

This will also run a package upgrades. And if that doesn't help you might want to delete the vendor directory and the composer.lock file and install it completely from scratch. (But you should check the package changes in the version control very carefully.

avasiliauskas commented 1 year ago

Thanks, closing issue, it seems there was my fault.