Sylius / Sylius-Sandbox

[DEPRACATED] Sylius sandbox application, playground and testing place for Sylius and Symfony2 beginners.
Sylius.org
MIT License
76 stars 24 forks source link

Depend on explicit jquery version. #91

Closed umpirsky closed 11 years ago

umpirsky commented 11 years ago

BTW, what do you think about moving javascripts block to the bottom, right before </body>?

pjedrzejewski commented 11 years ago

Big +1, I kept forgetting about this, would you mind adding it to this PR? Thanks!

umpirsky commented 11 years ago

I requires some additional changes, I don't want to break the demo now, we will handle that in separate PR.

One place where it can break is Backend/Zone/_form.html.twig where javascripts should be moved to some template which extends layout and {{ parent() }} added.

@pjedrzejewski Are you aware of any possible breaks other then this?

pjedrzejewski commented 11 years ago

Hm... nope... this is the only place for js other than the layout.

umpirsky commented 11 years ago

OK, I'll fix this today ;)

umpirsky commented 11 years ago

Fixed.

pjedrzejewski commented 11 years ago

Thank you sir!