search

Sylius / SyliusAdminApiBundle

Administration REST API for Sylius eCommerce.
MIT License
11 stars 22 forks source link

Add PHP 8.0 support to composer.json #7

Closed sasa-b closed 3 years ago

sasa-b commented 3 years ago

If we want to upgrade to Sylius 1.10.0 and keep the Sylius Admin Api bundle (point one in the upgrade guide https://github.com/Sylius/Sylius/blob/master/UPGRADE-1.10.md) while running it on PHP 8.0 we need this change in composer.json.

sasa-b commented 3 years ago

@pamil I've added the PHP 8.0 in the github build.yaml and I've also bumped the Sylius version to ~1.10.0 there as the Admin Api has been extracted to a separate bundle in that version.

dsbe-ak commented 3 years ago

Any updates? How can I run the api v1 with php 8?

sasa-b commented 3 years ago

@dsbe-ak I've forked this bundle and use the fork for the time being https://github.com/sasa-b/SyliusAdminApiBundle. After updating the gitflow build file as requested it is failing now and I don't have time to dig deeper.

dsbe-ak commented 3 years ago

So this is only failing because of test "CustomerApiTest::it_returns_page_not_found_if_limit_is_set_to_0", correct? In my opinion this has nothing to do with the update to php 8.0 (test is also failing for php 7.4).

Is this test method necessary at all?

Thanks

AdamKasp commented 3 years ago

replaced with #10