Sylius / SyliusElasticSearchPlugin

DEPRECATED! Use https://github.com/BitBagCommerce/SyliusElasticsearchPlugin instead.
22 stars 26 forks source link

Strict types, Variants, Options and Product population #58

Closed psihius closed 7 years ago

psihius commented 7 years ago

Implemented strict_types across the plugin. Added Product variants and options to the elastic index Updated ProductDocumentFactory to create Variants and Options and push those to Elastic.

psihius commented 7 years ago

Well, this ended up being a bit messy, especially because we both changed the ProductDocumentFactory and it turned out into a lot of merge conflicts, so I had to push in all my changes, otherwise this PR was unmergeable. There are a few things we talked over with @pamil and after this is merged I will create a new PR and this time will make sure I keep it small.

psihius commented 7 years ago

Tests are not in a very good place right now and I think we need @Arminek to help us out here a bit :) But I updated shop.yml fixtures - added product variants and product options and product option values to the mix, so we can test those too now.

PR is extending a lot here - adding support for variants, in stock filter, options filter, a few fixes by override for the FilterManagerBundle (there are things that just are plain wrong) and creates a few new filters because they require more than 1 nested level handling.

psihius commented 7 years ago

@lchrusciel @pamil ready for review, fixed so tests work. More work will be done on this in future PR's

pamil commented 7 years ago

Thanks @psihius, amazing work! 🎉